-- Object type constants

-- Affiliation

COMBATLOG_OBJECT_AFFILIATION_MINE		= 0x00000001;

COMBATLOG_OBJECT_AFFILIATION_PARTY		= 0x00000002;

COMBATLOG_OBJECT_AFFILIATION_RAID		= 0x00000004;

COMBATLOG_OBJECT_AFFILIATION_OUTSIDER	= 0x00000008;

COMBATLOG_OBJECT_AFFILIATION_MASK		= 0x0000000F;

-- Reaction

COMBATLOG_OBJECT_REACTION_FRIENDLY		= 0x00000010;

COMBATLOG_OBJECT_REACTION_NEUTRAL		= 0x00000020;

COMBATLOG_OBJECT_REACTION_HOSTILE		= 0x00000040;

COMBATLOG_OBJECT_REACTION_MASK		= 0x000000F0;

-- Ownership

COMBATLOG_OBJECT_CONTROL_PLAYER		= 0x00000100;

COMBATLOG_OBJECT_CONTROL_NPC		= 0x00000200;

COMBATLOG_OBJECT_CONTROL_MASK		= 0x00000300;

-- Unit type

COMBATLOG_OBJECT_TYPE_PLAYER		= 0x00000400;

COMBATLOG_OBJECT_TYPE_NPC			= 0x00000800;

COMBATLOG_OBJECT_TYPE_PET			= 0x00001000;

COMBATLOG_OBJECT_TYPE_GUARDIAN		= 0x00002000;

COMBATLOG_OBJECT_TYPE_OBJECT		= 0x00004000;

COMBATLOG_OBJECT_TYPE_MASK			= 0x0000FC00;

-- Special cases (non-exclusive)

COMBATLOG_OBJECT_TARGET			= 0x00010000;

COMBATLOG_OBJECT_FOCUS			= 0x00020000;

COMBATLOG_OBJECT_MAINTANK			= 0x00040000;

COMBATLOG_OBJECT_MAINASSIST			= 0x00080000;

COMBATLOG_OBJECT_RAIDTARGET1		= 0x00100000;

COMBATLOG_OBJECT_RAIDTARGET2		= 0x00200000;

COMBATLOG_OBJECT_RAIDTARGET3		= 0x00400000;

COMBATLOG_OBJECT_RAIDTARGET4		= 0x00800000;

COMBATLOG_OBJECT_RAIDTARGET5		= 0x01000000;

COMBATLOG_OBJECT_RAIDTARGET6		= 0x02000000;

COMBATLOG_OBJECT_RAIDTARGET7		= 0x04000000;

COMBATLOG_OBJECT_RAIDTARGET8		= 0x08000000;

COMBATLOG_OBJECT_NONE			= 0x80000000;

COMBATLOG_OBJECT_SPECIAL_MASK		= 0xFFFF0000;


COMBATLOG = ChatFrame2;


-- Process the event and add it to the combat log

function CombatLog_AddEvent(...)

local info = ChatTypeInfo["COMBAT_MISC_INFO"];

local timestamp, type, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags = select(1, ...);

local message = format("%s> %s, %s, %s, 0x%x, %s, %s, 0x%x",

date("%H:%M:%S", timestamp), type,

srcGUID, srcName or "nil", srcFlags,

dstGUID, dstName or "nil", dstFlags);

for i = 9, select("#", ...) do

message = message..", "..(select(i, ...) or "nil");

end

COMBATLOG:AddMessage(message, info.r, info.g, info.b);

end


-- Save the original event handler

local original_OnEvent = COMBATLOG:GetScript("OnEvent");

COMBATLOG:SetScript("OnEvent",

function(self, event, ...)

if ( event == "COMBAT_LOG_EVENT" ) then

CombatLog_AddEvent(...);

return;

end

original_OnEvent(self, event, ...);

end

);

COMBATLOG:RegisterEvent("COMBAT_LOG_EVENT");

[ Post edited by Slouken ]

-- Object type constants

-- Affiliation

COMBATLOG_OBJECT_AFFILIATION_MINE		= 0x00000001;

COMBATLOG_OBJECT_AFFILIATION_PARTY		= 0x00000002;

COMBATLOG_OBJECT_AFFILIATION_RAID		= 0x00000004;

COMBATLOG_OBJECT_AFFILIATION_OUTSIDER	= 0x00000008;

COMBATLOG_OBJECT_AFFILIATION_MASK		= 0x0000000F;

-- Reaction

COMBATLOG_OBJECT_REACTION_FRIENDLY		= 0x00000010;

COMBATLOG_OBJECT_REACTION_NEUTRAL		= 0x00000020;

COMBATLOG_OBJECT_REACTION_HOSTILE		= 0x00000040;

COMBATLOG_OBJECT_REACTION_MASK		= 0x000000F0;

-- Ownership

COMBATLOG_OBJECT_CONTROL_PLAYER		= 0x00000100;

COMBATLOG_OBJECT_CONTROL_NPC		= 0x00000200;

COMBATLOG_OBJECT_CONTROL_MASK		= 0x00000300;

-- Unit type

COMBATLOG_OBJECT_TYPE_PLAYER		= 0x00000400;

COMBATLOG_OBJECT_TYPE_NPC			= 0x00000800;

COMBATLOG_OBJECT_TYPE_PET			= 0x00001000;

COMBATLOG_OBJECT_TYPE_GUARDIAN		= 0x00002000;

COMBATLOG_OBJECT_TYPE_OBJECT		= 0x00004000;

COMBATLOG_OBJECT_TYPE_MASK			= 0x0000FC00;

-- Special cases (non-exclusive)

COMBATLOG_OBJECT_TARGET			= 0x00010000;

COMBATLOG_OBJECT_FOCUS			= 0x00020000;

COMBATLOG_OBJECT_MAINTANK			= 0x00040000;

COMBATLOG_OBJECT_MAINASSIST			= 0x00080000;

COMBATLOG_OBJECT_RAIDTARGET1		= 0x00100000;

COMBATLOG_OBJECT_RAIDTARGET2		= 0x00200000;

COMBATLOG_OBJECT_RAIDTARGET3		= 0x00400000;

COMBATLOG_OBJECT_RAIDTARGET4		= 0x00800000;

COMBATLOG_OBJECT_RAIDTARGET5		= 0x01000000;

COMBATLOG_OBJECT_RAIDTARGET6		= 0x02000000;

COMBATLOG_OBJECT_RAIDTARGET7		= 0x04000000;

COMBATLOG_OBJECT_RAIDTARGET8		= 0x08000000;

COMBATLOG_OBJECT_NONE			= 0x80000000;

COMBATLOG_OBJECT_SPECIAL_MASK		= 0xFFFF0000;


COMBATLOG = ChatFrame2;


-- Process the event and add it to the combat log

function CombatLog_AddEvent(...)

local info = ChatTypeInfo["COMBAT_MISC_INFO"];

local timestamp, type, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags = select(1, ...);

local message = format("%s> %s, %s, %s, 0x%x, %s, %s, 0x%x",

date("%H:%M:%S", timestamp), type,

srcGUID, srcName or "nil", srcFlags,

dstGUID, dstName or "nil", dstFlags);

for i = 9, select("#", ...) do

message = message..", "..(select(i, ...) or "nil");

end

COMBATLOG:AddMessage(message, info.r, info.g, info.b);

end


-- Save the original event handler

local original_OnEvent = COMBATLOG:GetScript("OnEvent");

COMBATLOG:SetScript("OnEvent",

function(self, event, ...)

if ( event == "COMBAT_LOG_EVENT" ) then

CombatLog_AddEvent(...);

return;

end

original_OnEvent(self, event, ...);

end

);

COMBATLOG:RegisterEvent("COMBAT_LOG_EVENT");

[ Post edited by Slouken ]

---

Q u o t e:
I know it's not final code, but is select(1, ...) in there instead of ... for any particular reason?

---

---

Q u o t e:

Slouken: Out of curiosity, will the old CHAT_MSG_COMBAT_... events still be sent, or will the new combat log event be the only one transmitted?

---

---

Q u o t e:
Slouken, your babies, can I have them please?

---

---

Q u o t e:

Will there be a way to to get a name/level/whatever from a GUID? Something analogous to UnitName(GUID)?

---

[ Post edited by Slouken ]

---

Q u o t e:

If enGB hasn't seen an event with 1234 yet, though, then they'll have no name to associate with 1234, and deDE can't pass across a name when asked for it, since they won't have the enGB equivalent. It'd be nice to get data via GUID to patch up holes like that, though admittedly, it won't be too critical so long as players have sane combat log ranges.

---

---

Q u o t e:

Man, I've been sent deaf by the cheers. And I'm all the way over the other side of the planet!

---

[ Post edited by Slouken ]

[ Post edited by Slouken ]

[ Post edited by Slouken ]

[ Post edited by Slouken ]

[ Post edited by Zootfizzle ]

---

Q u o t e:
I'm not sure if there is anything that currently is allowed in multiple types of bags. However there definitely are materials that are used by multiple professions. The API as presented would be a difficulty if those were ever made to go into more than one type of bag.

---

---

Q u o t e:

HA!!! I found it!
http://www.youtube.com/watch?v=aGpUX1FpA_I&NR=1
The question is at 5:50, the answer is at 7:30, with direct references to outfitter and itemrack. I'd have to do some extreme forum crawling to dig up the post mentioning this as a change in 2.4 specifically, but when else would it be implemented? WotLK?

And if you continue listening, there is mention of a built-in threat meter, which I presume goes hand-in-hand with the combat log changes that have been discussed at length in this thread.

---

Combat Log Settings -> Colors


Unit Colors:

Me 	-> Green

My Pet  -> Dark Green

Friends -> Blue

Enemies -> Red

Neutral -> Yellow

Colorize:

Unit Names	 	-> Checked

Spell Names 		-> Checked

Spell Color-by-School 	-> Checked

Damage Number	 	-> Checked

Damage Color-by-School  -> Checked

Damage School 		-> Checked

Entire Line 		-> Unchecked

All Highlighting Options-> Unchecked


Formatting:

Verbose 		-> Unchecked

Braces 			-> Checked

Timestamps 		-> Checked

• Source
  
• Target
  
• Events
  

• String
  
• Number
  

-- Affiliation

COMBATLOG_OBJECT_AFFILIATION_MINE		= 0x00000001;

COMBATLOG_OBJECT_AFFILIATION_PARTY		= 0x00000002;

COMBATLOG_OBJECT_AFFILIATION_RAID		= 0x00000004;

COMBATLOG_OBJECT_AFFILIATION_OUTSIDER		= 0x00000008;

COMBATLOG_OBJECT_AFFILIATION_MASK		= 0x0000000F;

-- Reaction

COMBATLOG_OBJECT_REACTION_FRIENDLY		= 0x00000010;

COMBATLOG_OBJECT_REACTION_NEUTRAL		= 0x00000020;

COMBATLOG_OBJECT_REACTION_HOSTILE		= 0x00000040;

COMBATLOG_OBJECT_REACTION_MASK			= 0x000000F0;

-- Ownership

COMBATLOG_OBJECT_CONTROL_PLAYER			= 0x00000100;

COMBATLOG_OBJECT_CONTROL_NPC			= 0x00000200;

COMBATLOG_OBJECT_CONTROL_MASK			= 0x00000300;

-- Unit type

COMBATLOG_OBJECT_TYPE_PLAYER			= 0x00000400;

COMBATLOG_OBJECT_TYPE_NPC			= 0x00000800;

COMBATLOG_OBJECT_TYPE_PET			= 0x00001000;

COMBATLOG_OBJECT_TYPE_GUARDIAN			= 0x00002000;

COMBATLOG_OBJECT_TYPE_OBJECT			= 0x00004000;

COMBATLOG_OBJECT_TYPE_MASK			= 0x0000FC00;


-- Special cases (non-exclusive)

COMBATLOG_OBJECT_TARGET				= 0x00010000;

COMBATLOG_OBJECT_FOCUS				= 0x00020000;

COMBATLOG_OBJECT_MAINTANK			= 0x00040000;

COMBATLOG_OBJECT_MAINASSIST			= 0x00080000;

COMBATLOG_OBJECT_RAIDTARGET1			= 0x00100000;

COMBATLOG_OBJECT_RAIDTARGET2			= 0x00200000;

COMBATLOG_OBJECT_RAIDTARGET3			= 0x00400000;

COMBATLOG_OBJECT_RAIDTARGET4			= 0x00800000;

COMBATLOG_OBJECT_RAIDTARGET5			= 0x01000000;

COMBATLOG_OBJECT_RAIDTARGET6			= 0x02000000;

COMBATLOG_OBJECT_RAIDTARGET7			= 0x04000000;

COMBATLOG_OBJECT_RAIDTARGET8			= 0x08000000;

COMBATLOG_OBJECT_NONE				= 0x80000000;

COMBATLOG_OBJECT_SPECIAL_MASK			= 0xFFFF0000;

COMBATLOG_FILTER_MINE	= bit.bor (

COMBATLOG_OBJECT_AFFILIATION_MINE,

COMBATLOG_OBJECT_REACTION_FRIENDLY,

COMBATLOG_OBJECT_CONTROL_PLAYER,

COMBATLOG_OBJECT_TYPE_PLAYER,

COMBATLOG_OBJECT_TYPE_OBJECT

);

COMBATLOG_FILTER_FRIENDLY_UNITS = bit.bor(

COMBATLOG_OBJECT_AFFILIATION_PARTY,

COMBATLOG_OBJECT_AFFILIATION_RAID,

COMBATLOG_OBJECT_AFFILIATION_OUTSIDER,

COMBATLOG_OBJECT_REACTION_FRIENDLY,

COMBATLOG_OBJECT_CONTROL_PLAYER,

COMBATLOG_OBJECT_CONTROL_NPC,

COMBATLOG_OBJECT_TYPE_PLAYER,

COMBATLOG_OBJECT_TYPE_NPC,

COMBATLOG_OBJECT_TYPE_PET,

COMBATLOG_OBJECT_TYPE_GUARDIAN,

COMBATLOG_OBJECT_TYPE_OBJECT

);

CombatLogAddFilter(nil,  COMBATLOG_FILTER_MINE, nil)

CombatLogAddFilter(nil, COMBATLOG_FILTER_HOSTILE_UNITS , COMBATLOG_FILTER_MINE nil)

[ Post edited by Slouken ]

---

Q u o t e:

Any way of posting (a few lines' worth of) a mock-up WoWCombatLog.txt file before 2.4 hits the PTR just so we can get an idea of what it will actually look like?

---

2/5 12:36:05.709  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:07.704  SWING_MISSED,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,DODGE

2/5 12:36:09.729  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:10.965  SPELL_CAST_START,0x0000000000427042,Foozle,0x511,0x0000000000000000,(null),0x80000000,331,Healing Wave,0x8

2/5 12:36:11.715  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:13.532  SPELL_HEAL,0x0000000000427042,Foozle,0x511,0x0000000000427042,Foozle,0x511,331,Healing Wave,0x8,44,nil

2/5 12:36:13.738  SWING_MISSED,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,DODGE

2/5 12:36:15.726  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:16.462  SPELL_CAST_START,0x0000000000427042,Foozle,0x511,0x0000000000000000,(null),0x80000000,403,Lightning Bolt,0x8

2/5 12:36:17.712  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:18.111  SPELL_DAMAGE,0x0000000000427042,Foozle,0x511,0xF13000002800192A,Kobold Miner,0x10a48,403,Lightning Bolt,0x8,16,8,nil,nil,nil,nil,nil,nil

2/5 12:36:19.729  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:20.689  SWING_DAMAGE,0x0000000000427042,Foozle,0x511,0xF13000002800192A,Kobold Miner,0x10a48,157,1,nil,nil,nil,nil,nil,nil

2/5 12:36:20.909  PARTY_KILL,0x0000000000427042,Foozle,0x511,0xF13000002800192A,Kobold Miner,0x10a48

2/5 12:36:21.311  UNIT_DIED,0x0000000000000000,(null),0x80000000,0xF13000002800192A,Kobold Miner,0x10a48

[ Post edited by Slouken ]

---

Q u o t e:

Just how dynamic are these GUIDs? For example, in any of the following situations, would a new GUID be generated?

---

---

Q u o t e:
We already have that, it's IsSpellInRange and CheckInteractDistance, and "In Range" is fairly vague given that can mean 10 different things.

---

---

Q u o t e:
will we be able to change that static range or is it hardcoded?

---

[ Post edited by Rislyn ]

---

Q u o t e:

HO-HO!!!!
Been asking for this for YEARS!!!!!!!!
http://forums.worldofwarcraft.com/thread.html?topicId=101150523&sid=1&pageNo=8#156
Thank you Slouken!!!!!!!!!!!!!!!!!!!!

---

[ Post edited by Zootfizzle ]

[ Post edited by Zootfizzle ]

---

Q u o t e:
Thanks. Still think it's a bug since 0 has meaning for this function so returning 0 just because the info isn't in the item cache is wrong. Function should return nil if it can't return the data I asked for.

---

---

Q u o t e:
I posted this to the Test Realm forums, but thought maybe here was more appropriate...

The affected party Name for the SPELL_ENERGIZE line as below is incorrect. The guid is correct, referring to "Mara", but the name listed is "Jerierex", whose guid is different. The two previous lines establish the guids of the two, and are consistent with the rest of the log file.

Either that, or I'm missing something big :)

2/12 06:32:20.840 SPELL_DAMAGE,0x000000000055C520,Mara,0x518,0xF1300061AA0F9B6F,Unleashed Hellion,0xa48,26862,Sinister Strike,0x1,1269,1,nil,nil,nil,1,nil,nil
2/12 06:32:21.231 SWING_DAMAGE,0x0000000000569D9B,Jerierex,0x518,0xF1300061A90F9F2F,Abyssal Flamewalker,0xa48,169,1,nil,nil,nil,nil,nil,nil
2/12 06:32:21.231 SPELL_ENERGIZE,0x000000000055C520,Mara,0x518,0x000000000055C520,Jerierex,0x518,35548,Combat Potency,0x1,15,3

---

---

Q u o t e:
One more: Just an inconsistency more than anything, but I figured you might change it now so it doesn't annoy too many others down the track :)

The first "Spell School" parameter is hex, the second where there is one is decimal.

---

---

Q u o t e:

Slouken, don't you go getting any ideas...he's mine! That is, unless I can have your babies...

---

---

Q u o t e:

Now what are the chances of a FEW(!!!) of the Unit*() functions accepting GUIDs? Just wanting informational ones like name, class, race, level, classification, creaturetype, creaturefamily, faction, sex, and buffs. Nothing like health, mana, castinginfo, or anything like that.

---

[ Post edited by Zootfizzle ]

---

Q u o t e:

Perhaps a useful function for addons would be an enhanced form of CombatLogGetCurrentEntry() that included an additional parameter to specify the Unfiltered combat log

---

---

Q u o t e:
and an additional parameter (or parameters) to specify the filter to apply. I think this would make sense

---

---

Q u o t e:
So going through combat logs, I see for some spells there is never a spell cast success message. In particular, i was looking for a spell cast success message for earth shield. Is there a reason we don't get messages for some spells?

---

---

Q u o t e:

Thanks for the change Slouken! How about the effective healing change? Is it at all possible?

---

---

Q u o t e:
Is it just me, or is the new combat log totally not picking up players dieing now? It worked fine on PTR, but now the UNIT_DIED event isn't firing for players dieing. So they're just not showing up - either in the ingame combat log or using /combatlog

---

---

Q u o t e:
Every player GUID i've run across so far begins with 0x00, i've been trying (with success so far, but who knows if there are counterexamples, I'd love to see them) to use the upper bits of the GUID to determine what kind of GUID it is, right now I have:

0xF13 -- NPC
0xF53 -- NPC

0xF14 -- PET
0xF54 -- PET

0x000 -- Player

(I haven't figured out if there's any useful significance of the 0xF1 versus 0xF5 thing)

---

[ Post edited by Slouken ]

-- Object type constants

-- Affiliation

COMBATLOG_OBJECT_AFFILIATION_MINE		= 0x00000001;

COMBATLOG_OBJECT_AFFILIATION_PARTY		= 0x00000002;

COMBATLOG_OBJECT_AFFILIATION_RAID		= 0x00000004;

COMBATLOG_OBJECT_AFFILIATION_OUTSIDER	= 0x00000008;

COMBATLOG_OBJECT_AFFILIATION_MASK		= 0x0000000F;

-- Reaction

COMBATLOG_OBJECT_REACTION_FRIENDLY		= 0x00000010;

COMBATLOG_OBJECT_REACTION_NEUTRAL		= 0x00000020;

COMBATLOG_OBJECT_REACTION_HOSTILE		= 0x00000040;

COMBATLOG_OBJECT_REACTION_MASK		= 0x000000F0;

-- Ownership

COMBATLOG_OBJECT_CONTROL_PLAYER		= 0x00000100;

COMBATLOG_OBJECT_CONTROL_NPC		= 0x00000200;

COMBATLOG_OBJECT_CONTROL_MASK		= 0x00000300;

-- Unit type

COMBATLOG_OBJECT_TYPE_PLAYER		= 0x00000400;

COMBATLOG_OBJECT_TYPE_NPC			= 0x00000800;

COMBATLOG_OBJECT_TYPE_PET			= 0x00001000;

COMBATLOG_OBJECT_TYPE_GUARDIAN		= 0x00002000;

COMBATLOG_OBJECT_TYPE_OBJECT		= 0x00004000;

COMBATLOG_OBJECT_TYPE_MASK			= 0x0000FC00;

-- Special cases (non-exclusive)

COMBATLOG_OBJECT_TARGET			= 0x00010000;

COMBATLOG_OBJECT_FOCUS			= 0x00020000;

COMBATLOG_OBJECT_MAINTANK			= 0x00040000;

COMBATLOG_OBJECT_MAINASSIST			= 0x00080000;

COMBATLOG_OBJECT_RAIDTARGET1		= 0x00100000;

COMBATLOG_OBJECT_RAIDTARGET2		= 0x00200000;

COMBATLOG_OBJECT_RAIDTARGET3		= 0x00400000;

COMBATLOG_OBJECT_RAIDTARGET4		= 0x00800000;

COMBATLOG_OBJECT_RAIDTARGET5		= 0x01000000;

COMBATLOG_OBJECT_RAIDTARGET6		= 0x02000000;

COMBATLOG_OBJECT_RAIDTARGET7		= 0x04000000;

COMBATLOG_OBJECT_RAIDTARGET8		= 0x08000000;

COMBATLOG_OBJECT_NONE			= 0x80000000;

COMBATLOG_OBJECT_SPECIAL_MASK		= 0xFFFF0000;


COMBATLOG = ChatFrame2;


-- Process the event and add it to the combat log

function CombatLog_AddEvent(...)

local info = ChatTypeInfo["COMBAT_MISC_INFO"];

local timestamp, type, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags = select(1, ...);

local message = format("%s> %s, %s, %s, 0x%x, %s, %s, 0x%x",

date("%H:%M:%S", timestamp), type,

srcGUID, srcName or "nil", srcFlags,

dstGUID, dstName or "nil", dstFlags);

for i = 9, select("#", ...) do

message = message..", "..(select(i, ...) or "nil");

end

COMBATLOG:AddMessage(message, info.r, info.g, info.b);

end


-- Save the original event handler

local original_OnEvent = COMBATLOG:GetScript("OnEvent");

COMBATLOG:SetScript("OnEvent",

function(self, event, ...)

if ( event == "COMBAT_LOG_EVENT" ) then

CombatLog_AddEvent(...);

return;

end

original_OnEvent(self, event, ...);

end

);

COMBATLOG:RegisterEvent("COMBAT_LOG_EVENT");

[ Post edited by Slouken ]

---

Q u o t e:
I know it's not final code, but is select(1, ...) in there instead of ... for any particular reason?

---

---

Q u o t e:

Slouken: Out of curiosity, will the old CHAT_MSG_COMBAT_... events still be sent, or will the new combat log event be the only one transmitted?

---

---

Q u o t e:
Slouken, your babies, can I have them please?

---

---

Q u o t e:

Will there be a way to to get a name/level/whatever from a GUID? Something analogous to UnitName(GUID)?

---

[ Post edited by Slouken ]

---

Q u o t e:

If enGB hasn't seen an event with 1234 yet, though, then they'll have no name to associate with 1234, and deDE can't pass across a name when asked for it, since they won't have the enGB equivalent. It'd be nice to get data via GUID to patch up holes like that, though admittedly, it won't be too critical so long as players have sane combat log ranges.

---

---

Q u o t e:

Man, I've been sent deaf by the cheers. And I'm all the way over the other side of the planet!

---

[ Post edited by Slouken ]

[ Post edited by Slouken ]

[ Post edited by Slouken ]

---

Q u o t e:
I'm not sure if there is anything that currently is allowed in multiple types of bags. However there definitely are materials that are used by multiple professions. The API as presented would be a difficulty if those were ever made to go into more than one type of bag.

---

---

Q u o t e:

HA!!! I found it!
http://www.youtube.com/watch?v=aGpUX1FpA_I&NR=1
The question is at 5:50, the answer is at 7:30, with direct references to outfitter and itemrack. I'd have to do some extreme forum crawling to dig up the post mentioning this as a change in 2.4 specifically, but when else would it be implemented? WotLK?

And if you continue listening, there is mention of a built-in threat meter, which I presume goes hand-in-hand with the combat log changes that have been discussed at length in this thread.

---

[ Post edited by Zootfizzle ]

Combat Log Settings -> Colors


Unit Colors:

Me 	-> Green

My Pet  -> Dark Green

Friends -> Blue

Enemies -> Red

Neutral -> Yellow

Colorize:

Unit Names	 	-> Checked

Spell Names 		-> Checked

Spell Color-by-School 	-> Checked

Damage Number	 	-> Checked

Damage Color-by-School  -> Checked

Damage School 		-> Checked

Entire Line 		-> Unchecked

All Highlighting Options-> Unchecked


Formatting:

Verbose 		-> Unchecked

Braces 			-> Checked

Timestamps 		-> Checked

• Source
  
• Target
  
• Events
  

• String
  
• Number
  

-- Affiliation

COMBATLOG_OBJECT_AFFILIATION_MINE		= 0x00000001;

COMBATLOG_OBJECT_AFFILIATION_PARTY		= 0x00000002;

COMBATLOG_OBJECT_AFFILIATION_RAID		= 0x00000004;

COMBATLOG_OBJECT_AFFILIATION_OUTSIDER		= 0x00000008;

COMBATLOG_OBJECT_AFFILIATION_MASK		= 0x0000000F;

-- Reaction

COMBATLOG_OBJECT_REACTION_FRIENDLY		= 0x00000010;

COMBATLOG_OBJECT_REACTION_NEUTRAL		= 0x00000020;

COMBATLOG_OBJECT_REACTION_HOSTILE		= 0x00000040;

COMBATLOG_OBJECT_REACTION_MASK			= 0x000000F0;

-- Ownership

COMBATLOG_OBJECT_CONTROL_PLAYER			= 0x00000100;

COMBATLOG_OBJECT_CONTROL_NPC			= 0x00000200;

COMBATLOG_OBJECT_CONTROL_MASK			= 0x00000300;

-- Unit type

COMBATLOG_OBJECT_TYPE_PLAYER			= 0x00000400;

COMBATLOG_OBJECT_TYPE_NPC			= 0x00000800;

COMBATLOG_OBJECT_TYPE_PET			= 0x00001000;

COMBATLOG_OBJECT_TYPE_GUARDIAN			= 0x00002000;

COMBATLOG_OBJECT_TYPE_OBJECT			= 0x00004000;

COMBATLOG_OBJECT_TYPE_MASK			= 0x0000FC00;


-- Special cases (non-exclusive)

COMBATLOG_OBJECT_TARGET				= 0x00010000;

COMBATLOG_OBJECT_FOCUS				= 0x00020000;

COMBATLOG_OBJECT_MAINTANK			= 0x00040000;

COMBATLOG_OBJECT_MAINASSIST			= 0x00080000;

COMBATLOG_OBJECT_RAIDTARGET1			= 0x00100000;

COMBATLOG_OBJECT_RAIDTARGET2			= 0x00200000;

COMBATLOG_OBJECT_RAIDTARGET3			= 0x00400000;

COMBATLOG_OBJECT_RAIDTARGET4			= 0x00800000;

COMBATLOG_OBJECT_RAIDTARGET5			= 0x01000000;

COMBATLOG_OBJECT_RAIDTARGET6			= 0x02000000;

COMBATLOG_OBJECT_RAIDTARGET7			= 0x04000000;

COMBATLOG_OBJECT_RAIDTARGET8			= 0x08000000;

COMBATLOG_OBJECT_NONE				= 0x80000000;

COMBATLOG_OBJECT_SPECIAL_MASK			= 0xFFFF0000;

COMBATLOG_FILTER_MINE	= bit.bor (

COMBATLOG_OBJECT_AFFILIATION_MINE,

COMBATLOG_OBJECT_REACTION_FRIENDLY,

COMBATLOG_OBJECT_CONTROL_PLAYER,

COMBATLOG_OBJECT_TYPE_PLAYER,

COMBATLOG_OBJECT_TYPE_OBJECT

);

COMBATLOG_FILTER_FRIENDLY_UNITS = bit.bor(

COMBATLOG_OBJECT_AFFILIATION_PARTY,

COMBATLOG_OBJECT_AFFILIATION_RAID,

COMBATLOG_OBJECT_AFFILIATION_OUTSIDER,

COMBATLOG_OBJECT_REACTION_FRIENDLY,

COMBATLOG_OBJECT_CONTROL_PLAYER,

COMBATLOG_OBJECT_CONTROL_NPC,

COMBATLOG_OBJECT_TYPE_PLAYER,

COMBATLOG_OBJECT_TYPE_NPC,

COMBATLOG_OBJECT_TYPE_PET,

COMBATLOG_OBJECT_TYPE_GUARDIAN,

COMBATLOG_OBJECT_TYPE_OBJECT

);

CombatLogAddFilter(nil,  COMBATLOG_FILTER_MINE, nil)

CombatLogAddFilter(nil, COMBATLOG_FILTER_HOSTILE_UNITS , COMBATLOG_FILTER_MINE nil)

[ Post edited by Slouken ]

---

Q u o t e:

Any way of posting (a few lines' worth of) a mock-up WoWCombatLog.txt file before 2.4 hits the PTR just so we can get an idea of what it will actually look like?

---

2/5 12:36:05.709  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:07.704  SWING_MISSED,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,DODGE

2/5 12:36:09.729  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:10.965  SPELL_CAST_START,0x0000000000427042,Foozle,0x511,0x0000000000000000,(null),0x80000000,331,Healing Wave,0x8

2/5 12:36:11.715  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:13.532  SPELL_HEAL,0x0000000000427042,Foozle,0x511,0x0000000000427042,Foozle,0x511,331,Healing Wave,0x8,44,nil

2/5 12:36:13.738  SWING_MISSED,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,DODGE

2/5 12:36:15.726  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:16.462  SPELL_CAST_START,0x0000000000427042,Foozle,0x511,0x0000000000000000,(null),0x80000000,403,Lightning Bolt,0x8

2/5 12:36:17.712  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:18.111  SPELL_DAMAGE,0x0000000000427042,Foozle,0x511,0xF13000002800192A,Kobold Miner,0x10a48,403,Lightning Bolt,0x8,16,8,nil,nil,nil,nil,nil,nil

2/5 12:36:19.729  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:20.689  SWING_DAMAGE,0x0000000000427042,Foozle,0x511,0xF13000002800192A,Kobold Miner,0x10a48,157,1,nil,nil,nil,nil,nil,nil

2/5 12:36:20.909  PARTY_KILL,0x0000000000427042,Foozle,0x511,0xF13000002800192A,Kobold Miner,0x10a48

2/5 12:36:21.311  UNIT_DIED,0x0000000000000000,(null),0x80000000,0xF13000002800192A,Kobold Miner,0x10a48

[ Post edited by Slouken ]

---

Q u o t e:

Just how dynamic are these GUIDs? For example, in any of the following situations, would a new GUID be generated?

---

---

Q u o t e:
We already have that, it's IsSpellInRange and CheckInteractDistance, and "In Range" is fairly vague given that can mean 10 different things.

---

---

Q u o t e:
will we be able to change that static range or is it hardcoded?

---

[ Post edited by Rislyn ]

---

Q u o t e:

HO-HO!!!!
Been asking for this for YEARS!!!!!!!!
http://forums.worldofwarcraft.com/thread.html?topicId=101150523&sid=1&pageNo=8#156
Thank you Slouken!!!!!!!!!!!!!!!!!!!!

---

[ Post edited by Zootfizzle ]

[ Post edited by Zootfizzle ]

---

Q u o t e:
Thanks. Still think it's a bug since 0 has meaning for this function so returning 0 just because the info isn't in the item cache is wrong. Function should return nil if it can't return the data I asked for.

---

---

Q u o t e:
I posted this to the Test Realm forums, but thought maybe here was more appropriate...

The affected party Name for the SPELL_ENERGIZE line as below is incorrect. The guid is correct, referring to "Mara", but the name listed is "Jerierex", whose guid is different. The two previous lines establish the guids of the two, and are consistent with the rest of the log file.

Either that, or I'm missing something big :)

2/12 06:32:20.840 SPELL_DAMAGE,0x000000000055C520,Mara,0x518,0xF1300061AA0F9B6F,Unleashed Hellion,0xa48,26862,Sinister Strike,0x1,1269,1,nil,nil,nil,1,nil,nil
2/12 06:32:21.231 SWING_DAMAGE,0x0000000000569D9B,Jerierex,0x518,0xF1300061A90F9F2F,Abyssal Flamewalker,0xa48,169,1,nil,nil,nil,nil,nil,nil
2/12 06:32:21.231 SPELL_ENERGIZE,0x000000000055C520,Mara,0x518,0x000000000055C520,Jerierex,0x518,35548,Combat Potency,0x1,15,3

---

---

Q u o t e:
One more: Just an inconsistency more than anything, but I figured you might change it now so it doesn't annoy too many others down the track :)

The first "Spell School" parameter is hex, the second where there is one is decimal.

---

---

Q u o t e:

Perhaps a useful function for addons would be an enhanced form of CombatLogGetCurrentEntry() that included an additional parameter to specify the Unfiltered combat log

---

---

Q u o t e:
and an additional parameter (or parameters) to specify the filter to apply. I think this would make sense

---

---

Q u o t e:
So going through combat logs, I see for some spells there is never a spell cast success message. In particular, i was looking for a spell cast success message for earth shield. Is there a reason we don't get messages for some spells?

---

---

Q u o t e:

Thanks for the change Slouken! How about the effective healing change? Is it at all possible?

---

---

Q u o t e:
Is it just me, or is the new combat log totally not picking up players dieing now? It worked fine on PTR, but now the UNIT_DIED event isn't firing for players dieing. So they're just not showing up - either in the ingame combat log or using /combatlog

---

---

Q u o t e:
Every player GUID i've run across so far begins with 0x00, i've been trying (with success so far, but who knows if there are counterexamples, I'd love to see them) to use the upper bits of the GUID to determine what kind of GUID it is, right now I have:

0xF13 -- NPC
0xF53 -- NPC

0xF14 -- PET
0xF54 -- PET

0x000 -- Player

(I haven't figured out if there's any useful significance of the 0xF1 versus 0xF5 thing)

---

[ Post edited by Slouken ]

-- Object type constants

-- Affiliation

COMBATLOG_OBJECT_AFFILIATION_MINE		= 0x00000001;

COMBATLOG_OBJECT_AFFILIATION_PARTY		= 0x00000002;

COMBATLOG_OBJECT_AFFILIATION_RAID		= 0x00000004;

COMBATLOG_OBJECT_AFFILIATION_OUTSIDER	= 0x00000008;

COMBATLOG_OBJECT_AFFILIATION_MASK		= 0x0000000F;

-- Reaction

COMBATLOG_OBJECT_REACTION_FRIENDLY		= 0x00000010;

COMBATLOG_OBJECT_REACTION_NEUTRAL		= 0x00000020;

COMBATLOG_OBJECT_REACTION_HOSTILE		= 0x00000040;

COMBATLOG_OBJECT_REACTION_MASK		= 0x000000F0;

-- Ownership

COMBATLOG_OBJECT_CONTROL_PLAYER		= 0x00000100;

COMBATLOG_OBJECT_CONTROL_NPC		= 0x00000200;

COMBATLOG_OBJECT_CONTROL_MASK		= 0x00000300;

-- Unit type

COMBATLOG_OBJECT_TYPE_PLAYER		= 0x00000400;

COMBATLOG_OBJECT_TYPE_NPC			= 0x00000800;

COMBATLOG_OBJECT_TYPE_PET			= 0x00001000;

COMBATLOG_OBJECT_TYPE_GUARDIAN		= 0x00002000;

COMBATLOG_OBJECT_TYPE_OBJECT		= 0x00004000;

COMBATLOG_OBJECT_TYPE_MASK			= 0x0000FC00;

-- Special cases (non-exclusive)

COMBATLOG_OBJECT_TARGET			= 0x00010000;

COMBATLOG_OBJECT_FOCUS			= 0x00020000;

COMBATLOG_OBJECT_MAINTANK			= 0x00040000;

COMBATLOG_OBJECT_MAINASSIST			= 0x00080000;

COMBATLOG_OBJECT_RAIDTARGET1		= 0x00100000;

COMBATLOG_OBJECT_RAIDTARGET2		= 0x00200000;

COMBATLOG_OBJECT_RAIDTARGET3		= 0x00400000;

COMBATLOG_OBJECT_RAIDTARGET4		= 0x00800000;

COMBATLOG_OBJECT_RAIDTARGET5		= 0x01000000;

COMBATLOG_OBJECT_RAIDTARGET6		= 0x02000000;

COMBATLOG_OBJECT_RAIDTARGET7		= 0x04000000;

COMBATLOG_OBJECT_RAIDTARGET8		= 0x08000000;

COMBATLOG_OBJECT_NONE			= 0x80000000;

COMBATLOG_OBJECT_SPECIAL_MASK		= 0xFFFF0000;


COMBATLOG = ChatFrame2;


-- Process the event and add it to the combat log

function CombatLog_AddEvent(...)

local info = ChatTypeInfo["COMBAT_MISC_INFO"];

local timestamp, type, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags = select(1, ...);

local message = format("%s> %s, %s, %s, 0x%x, %s, %s, 0x%x",

date("%H:%M:%S", timestamp), type,

srcGUID, srcName or "nil", srcFlags,

dstGUID, dstName or "nil", dstFlags);

for i = 9, select("#", ...) do

message = message..", "..(select(i, ...) or "nil");

end

COMBATLOG:AddMessage(message, info.r, info.g, info.b);

end


-- Save the original event handler

local original_OnEvent = COMBATLOG:GetScript("OnEvent");

COMBATLOG:SetScript("OnEvent",

function(self, event, ...)

if ( event == "COMBAT_LOG_EVENT" ) then

CombatLog_AddEvent(...);

return;

end

original_OnEvent(self, event, ...);

end

);

COMBATLOG:RegisterEvent("COMBAT_LOG_EVENT");

[ Post edited by Slouken ]

---

Q u o t e:
I know it's not final code, but is select(1, ...) in there instead of ... for any particular reason?

---

---

Q u o t e:

Slouken: Out of curiosity, will the old CHAT_MSG_COMBAT_... events still be sent, or will the new combat log event be the only one transmitted?

---

---

Q u o t e:
Slouken, your babies, can I have them please?

---

---

Q u o t e:

Will there be a way to to get a name/level/whatever from a GUID? Something analogous to UnitName(GUID)?

---

[ Post edited by Slouken ]

---

Q u o t e:

If enGB hasn't seen an event with 1234 yet, though, then they'll have no name to associate with 1234, and deDE can't pass across a name when asked for it, since they won't have the enGB equivalent. It'd be nice to get data via GUID to patch up holes like that, though admittedly, it won't be too critical so long as players have sane combat log ranges.

---

---

Q u o t e:

Man, I've been sent deaf by the cheers. And I'm all the way over the other side of the planet!

---

[ Post edited by Slouken ]

[ Post edited by Slouken ]

[ Post edited by Slouken ]

---

Q u o t e:
I'm not sure if there is anything that currently is allowed in multiple types of bags. However there definitely are materials that are used by multiple professions. The API as presented would be a difficulty if those were ever made to go into more than one type of bag.

---

---

Q u o t e:

HA!!! I found it!
http://www.youtube.com/watch?v=aGpUX1FpA_I&NR=1
The question is at 5:50, the answer is at 7:30, with direct references to outfitter and itemrack. I'd have to do some extreme forum crawling to dig up the post mentioning this as a change in 2.4 specifically, but when else would it be implemented? WotLK?

And if you continue listening, there is mention of a built-in threat meter, which I presume goes hand-in-hand with the combat log changes that have been discussed at length in this thread.

---

[ Post edited by Zootfizzle ]

Combat Log Settings -> Colors


Unit Colors:

Me 	-> Green

My Pet  -> Dark Green

Friends -> Blue

Enemies -> Red

Neutral -> Yellow

Colorize:

Unit Names	 	-> Checked

Spell Names 		-> Checked

Spell Color-by-School 	-> Checked

Damage Number	 	-> Checked

Damage Color-by-School  -> Checked

Damage School 		-> Checked

Entire Line 		-> Unchecked

All Highlighting Options-> Unchecked


Formatting:

Verbose 		-> Unchecked

Braces 			-> Checked

Timestamps 		-> Checked

• Source
  
• Target
  
• Events
  

• String
  
• Number
  

-- Affiliation

COMBATLOG_OBJECT_AFFILIATION_MINE		= 0x00000001;

COMBATLOG_OBJECT_AFFILIATION_PARTY		= 0x00000002;

COMBATLOG_OBJECT_AFFILIATION_RAID		= 0x00000004;

COMBATLOG_OBJECT_AFFILIATION_OUTSIDER		= 0x00000008;

COMBATLOG_OBJECT_AFFILIATION_MASK		= 0x0000000F;

-- Reaction

COMBATLOG_OBJECT_REACTION_FRIENDLY		= 0x00000010;

COMBATLOG_OBJECT_REACTION_NEUTRAL		= 0x00000020;

COMBATLOG_OBJECT_REACTION_HOSTILE		= 0x00000040;

COMBATLOG_OBJECT_REACTION_MASK			= 0x000000F0;

-- Ownership

COMBATLOG_OBJECT_CONTROL_PLAYER			= 0x00000100;

COMBATLOG_OBJECT_CONTROL_NPC			= 0x00000200;

COMBATLOG_OBJECT_CONTROL_MASK			= 0x00000300;

-- Unit type

COMBATLOG_OBJECT_TYPE_PLAYER			= 0x00000400;

COMBATLOG_OBJECT_TYPE_NPC			= 0x00000800;

COMBATLOG_OBJECT_TYPE_PET			= 0x00001000;

COMBATLOG_OBJECT_TYPE_GUARDIAN			= 0x00002000;

COMBATLOG_OBJECT_TYPE_OBJECT			= 0x00004000;

COMBATLOG_OBJECT_TYPE_MASK			= 0x0000FC00;


-- Special cases (non-exclusive)

COMBATLOG_OBJECT_TARGET				= 0x00010000;

COMBATLOG_OBJECT_FOCUS				= 0x00020000;

COMBATLOG_OBJECT_MAINTANK			= 0x00040000;

COMBATLOG_OBJECT_MAINASSIST			= 0x00080000;

COMBATLOG_OBJECT_RAIDTARGET1			= 0x00100000;

COMBATLOG_OBJECT_RAIDTARGET2			= 0x00200000;

COMBATLOG_OBJECT_RAIDTARGET3			= 0x00400000;

COMBATLOG_OBJECT_RAIDTARGET4			= 0x00800000;

COMBATLOG_OBJECT_RAIDTARGET5			= 0x01000000;

COMBATLOG_OBJECT_RAIDTARGET6			= 0x02000000;

COMBATLOG_OBJECT_RAIDTARGET7			= 0x04000000;

COMBATLOG_OBJECT_RAIDTARGET8			= 0x08000000;

COMBATLOG_OBJECT_NONE				= 0x80000000;

COMBATLOG_OBJECT_SPECIAL_MASK			= 0xFFFF0000;

COMBATLOG_FILTER_MINE	= bit.bor (

COMBATLOG_OBJECT_AFFILIATION_MINE,

COMBATLOG_OBJECT_REACTION_FRIENDLY,

COMBATLOG_OBJECT_CONTROL_PLAYER,

COMBATLOG_OBJECT_TYPE_PLAYER,

COMBATLOG_OBJECT_TYPE_OBJECT

);

COMBATLOG_FILTER_FRIENDLY_UNITS = bit.bor(

COMBATLOG_OBJECT_AFFILIATION_PARTY,

COMBATLOG_OBJECT_AFFILIATION_RAID,

COMBATLOG_OBJECT_AFFILIATION_OUTSIDER,

COMBATLOG_OBJECT_REACTION_FRIENDLY,

COMBATLOG_OBJECT_CONTROL_PLAYER,

COMBATLOG_OBJECT_CONTROL_NPC,

COMBATLOG_OBJECT_TYPE_PLAYER,

COMBATLOG_OBJECT_TYPE_NPC,

COMBATLOG_OBJECT_TYPE_PET,

COMBATLOG_OBJECT_TYPE_GUARDIAN,

COMBATLOG_OBJECT_TYPE_OBJECT

);

CombatLogAddFilter(nil,  COMBATLOG_FILTER_MINE, nil)

CombatLogAddFilter(nil, COMBATLOG_FILTER_HOSTILE_UNITS , COMBATLOG_FILTER_MINE nil)

[ Post edited by Slouken ]

---

Q u o t e:

Any way of posting (a few lines' worth of) a mock-up WoWCombatLog.txt file before 2.4 hits the PTR just so we can get an idea of what it will actually look like?

---

2/5 12:36:05.709  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:07.704  SWING_MISSED,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,DODGE

2/5 12:36:09.729  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:10.965  SPELL_CAST_START,0x0000000000427042,Foozle,0x511,0x0000000000000000,(null),0x80000000,331,Healing Wave,0x8

2/5 12:36:11.715  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:13.532  SPELL_HEAL,0x0000000000427042,Foozle,0x511,0x0000000000427042,Foozle,0x511,331,Healing Wave,0x8,44,nil

2/5 12:36:13.738  SWING_MISSED,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,DODGE

2/5 12:36:15.726  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:16.462  SPELL_CAST_START,0x0000000000427042,Foozle,0x511,0x0000000000000000,(null),0x80000000,403,Lightning Bolt,0x8

2/5 12:36:17.712  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:18.111  SPELL_DAMAGE,0x0000000000427042,Foozle,0x511,0xF13000002800192A,Kobold Miner,0x10a48,403,Lightning Bolt,0x8,16,8,nil,nil,nil,nil,nil,nil

2/5 12:36:19.729  SWING_DAMAGE,0xF13000002800192A,Kobold Miner,0x10a48,0x0000000000427042,Foozle,0x511,5,1,nil,nil,nil,nil,nil,nil

2/5 12:36:20.689  SWING_DAMAGE,0x0000000000427042,Foozle,0x511,0xF13000002800192A,Kobold Miner,0x10a48,157,1,nil,nil,nil,nil,nil,nil

2/5 12:36:20.909  PARTY_KILL,0x0000000000427042,Foozle,0x511,0xF13000002800192A,Kobold Miner,0x10a48

2/5 12:36:21.311  UNIT_DIED,0x0000000000000000,(null),0x80000000,0xF13000002800192A,Kobold Miner,0x10a48

[ Post edited by Slouken ]

---

Q u o t e:

Just how dynamic are these GUIDs? For example, in any of the following situations, would a new GUID be generated?

---

---

Q u o t e:
We already have that, it's IsSpellInRange and CheckInteractDistance, and "In Range" is fairly vague given that can mean 10 different things.

---

---

Q u o t e:
will we be able to change that static range or is it hardcoded?

---

[ Post edited by Rislyn ]

---

Q u o t e:

HO-HO!!!!
Been asking for this for YEARS!!!!!!!!
http://forums.worldofwarcraft.com/thread.html?topicId=101150523&sid=1&pageNo=8#156
Thank you Slouken!!!!!!!!!!!!!!!!!!!!

---

[ Post edited by Zootfizzle ]

[ Post edited by Zootfizzle ]

---

Q u o t e:
Thanks. Still think it's a bug since 0 has meaning for this function so returning 0 just because the info isn't in the item cache is wrong. Function should return nil if it can't return the data I asked for.

---

---

Q u o t e:
I posted this to the Test Realm forums, but thought maybe here was more appropriate...

The affected party Name for the SPELL_ENERGIZE line as below is incorrect. The guid is correct, referring to "Mara", but the name listed is "Jerierex", whose guid is different. The two previous lines establish the guids of the two, and are consistent with the rest of the log file.

Either that, or I'm missing something big :)

2/12 06:32:20.840 SPELL_DAMAGE,0x000000000055C520,Mara,0x518,0xF1300061AA0F9B6F,Unleashed Hellion,0xa48,26862,Sinister Strike,0x1,1269,1,nil,nil,nil,1,nil,nil
2/12 06:32:21.231 SWING_DAMAGE,0x0000000000569D9B,Jerierex,0x518,0xF1300061A90F9F2F,Abyssal Flamewalker,0xa48,169,1,nil,nil,nil,nil,nil,nil
2/12 06:32:21.231 SPELL_ENERGIZE,0x000000000055C520,Mara,0x518,0x000000000055C520,Jerierex,0x518,35548,Combat Potency,0x1,15,3

---

---

Q u o t e:
One more: Just an inconsistency more than anything, but I figured you might change it now so it doesn't annoy too many others down the track :)

The first "Spell School" parameter is hex, the second where there is one is decimal.

---

---

Q u o t e:

Perhaps a useful function for addons would be an enhanced form of CombatLogGetCurrentEntry() that included an additional parameter to specify the Unfiltered combat log

---

---

Q u o t e:
and an additional parameter (or parameters) to specify the filter to apply. I think this would make sense

---

---

Q u o t e:
So going through combat logs, I see for some spells there is never a spell cast success message. In particular, i was looking for a spell cast success message for earth shield. Is there a reason we don't get messages for some spells?

---

---

Q u o t e:

Thanks for the change Slouken! How about the effective healing change? Is it at all possible?

---

---

Q u o t e:
Is it just me, or is the new combat log totally not picking up players dieing now? It worked fine on PTR, but now the UNIT_DIED event isn't firing for players dieing. So they're just not showing up - either in the ingame combat log or using /combatlog

---

---

Q u o t e:
Every player GUID i've run across so far begins with 0x00, i've been trying (with success so far, but who knows if there are counterexamples, I'd love to see them) to use the upper bits of the GUID to determine what kind of GUID it is, right now I have:

0xF13 -- NPC
0xF53 -- NPC

0xF14 -- PET
0xF54 -- PET

0x000 -- Player

(I haven't figured out if there's any useful significance of the 0xF1 versus 0xF5 thing)

---

[ Post edited by Slouken ]

---

Q u o t e:

Is there any way to properly pass the GUID to APIs that currently use ("unit")? Even in a round-a-bout way?

---

---

Q u o t e:
A request!

The addon list in the Interface options panel seems to sort by the order panels were registered. This is rather annoying really, addons don't always load up in alpha order, nor do they always register their panel OnLoad... Could the default behavior be changed to sorting base categories in alpha order, and subcats in the order the addon registers them (it currently seems subcats sort in reverse order of when they were registered).

Naturally I tried to fix this myself, but the table that stores panels is a local... it's not exposed in any way I COULD fix it.

---

---

Q u o t e:

Unfortunately there's currently (also in 2.4.2 on ptr as of this morning) no escaping for quotes inside the names. This produces lines like the (utterly fabulous):

5/1 14:11:05.819 SPELL_CAST_SUCCESS, 0x0000000000A007BE, "Elfled", 0x511, 0xF130005D580018E8, ""Dirty" Michael Crowe", 0x10a18,6078, "Renew", 0x2

---

---

Q u o t e:
have they fixed the missing SPELL_CAST_SUCCESS or SPELL_CAST_START event on patch 2.4.3?
or will it be on the next next patch...

---