Poster: Renyun at 7/21/2006 4:05:13 AM PDT
Subject: Slouken: Please add a toggle for bag scaling |
| |
Right now, I'm using a kludge:
CONTAINER_SCALE = 1/GetCVar("uiScale);
This effectively disables it. However, I really think that there should be an option exposed in Interface Options to simply diable it.
On my system, I run WoW with uiScale set to 0.64. The bag scaling only makes things painful for me, with the scaling that I use.
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post418680 |
| |
Poster: Rislyn at 7/21/2006 10:32:35 AM PDT
Subject: Re: Slouken: Please add a toggle for bag scal |
| |
What resolutions are you running your client at? I put in a few checks for smaller UI scales and it shouldn't scale down to an unusable level. The way the bag scaling was built was to only scale if your bags would overlap your Bank Frame.
Would you mind posting a screenshot of your bags when they're scaled?
Thanks!
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post418814 |
Poster: Rislyn at 7/21/2006 1:58:29 PM PDT
Subject: Re: Slouken: Please add a toggle for bag scal |
| |
Hihi :)
They put me right to work! They said I was here to help reduce the workload, but we just keep getting more and more to do. That's a good thing, right?
Now, I just gotta make sure people are happy with the work I do. :):)
Where's my screenshot? ;)
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post418910 |
Poster: Rislyn at 7/24/2006 1:12:34 PM PDT
Subject: Re: Slouken: Please add a toggle for bag scal |
| |
From the looks of Brawnhide's bags, it looks like they're already being affected by the automatic scaling, is that correct? One thing I can look at is reducing the amount of scale when the bags overlap. I can also look at the measuring point at which they do.
If the problem lies in Movable Bags, then perhaps this does call for a conversation with the Movable Bags developers on fixing it. Or perhaps they can consider including the ability to turn it off within it.
Ultimately, however, since a very small portion of the community will encounter this feature in the first place, it doesn't really warrant its own UI Option.
Sorry. :(
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post420415 |
Poster: Rislyn at 7/25/2006 11:00:16 AM PDT
Subject: Re: Slouken: Please add a toggle for bag scal |
| |
What I can do is provide a check within the code to make sure there's a floor for the scaling (i.e. it will never scale below a scale of .75). I can also put in a vertical overlap check for the bags in case the right edge of the BankFrame does overlap, but the bottom edge doesn't. In your case, Renyun, that should keep the bags from scaling.
Rather than offering a global or a switch, I'd rather make the scaling feature rock solid so that you don't have to worry about it. :)
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post420824 |
Poster: Rislyn at 7/26/2006 6:43:04 PM PDT
Subject: Re: Slouken: Please add a toggle for bag scal |
| |
Mygrane, are you actually getting an error? If so, please post the text of your error.
I spent far too much time yesterday trying to get something working for a vertical check for the bags, but instead I unconvered a strange anchoring anomoly that's kept me from being able to implement it. It's driving me nuts trying to figure out, but I'm not sure if I can spend too much more time working at it. For some reason, when I add the vertical check to a bag that is not the starter of a new column, whenever bags are closed, I get an error that one of the frames on redraw can't GetLeft() or GetTop() (value is nil). Typically it's ContainerFrame2 and there's something weird going on with the anchoring. If one of you can figure out what's going on to fix it, then I can definitely implement it. :)
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post421850 |
Poster: Rislyn at 7/27/2006 11:09:30 AM PDT
Subject: Re: Slouken: Please add a toggle for bag scal |
| |
I can't paste the code, but I can point you to where it is...
in ContainerFrame.lua, there's the updateContainerFrameAnchors() function. Within that function is the horizontal check for the container draw, at the start of a new column.
if ( BankFrame:IsShown() ) then
if ( frame:GetLeft() < ( BankFrame:GetRight() - 45 ) ) then
shrinkFrames = 1;
break;
end
end
I added a condition of "and ( frame:GetTop() > BankFrame:GetBottom() )", and moved it to just outside the anchoring portion of the loop, right before the freeScreenHeight calculation. When placed there, it works as intended, except when openning and closing the bags using Shift-B (all at once). At that point the frame does exist, but doesn't have a Top or Left value because something is happening too quickly for it to be anchored before they actually draw.
Not quite the mystery of the ages, but something I just have too much other work to do to spend time on. Iriel, you think you could take a crack at figuring it out? :)
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post422157 |
Poster: Rislyn at 7/27/2006 2:25:42 PM PDT
Subject: Re: Slouken: Please add a toggle for bag scal |
| |
The reason behind our shrinking the bags is so that bags wouldn't draw behind the BankFrame as they currently do. With the shrinking, you can have ALL of your bags open at once, without having to open and close them just to see the contents. I will definitely make a minimum container scale so that they don't become unusably small, though.
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post422273 |
Poster: Rislyn at 7/27/2006 2:45:54 PM PDT
Subject: Re: Slouken: Please add a toggle for bag scal |
| |
You're right about that bit of code. In my cleaning up of the scaling, I've removed all of that and have it working far better. I've also reduced the effective scale to 0.92 in order to minimize the neccesary shrinkage. I think that code was initially put due to a difference in how scaling was handled.
Your work around would also need to include the value of BankFrame:GetTop() relative to the top of the frame. Sadly, that's doesn't account for the frame:GetLeft() check that needs to happen at the same time.[ post edited by Rislyn ]
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post422288 |
Poster: Rislyn at 7/27/2006 3:05:24 PM PDT
Subject: Re: Slouken: Please add a toggle for bag scal |
| |
That code was in there for a reason: to accomidate for those at the higher end of the spectrum for uiScaling (90+), to make sure they scaled enough. I'm poking around some more trying to find the right "middle ground".
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post422308 |
Poster: Rislyn at 7/27/2006 3:18:43 PM PDT
Subject: Re: Slouken: Please add a toggle for bag scal |
| |
When you have a uiScale less than your containerScale, you don't want your bags growing instead of shrinking . I think I meant to say at the "lower end of the spectrum". And that, of course, was dependant on the old way of scaling bags, rather than the inherent scaling we have now.
Something strange has happened though: my new vertical check (different than your work around) is now working (strange voodoo is afoot). This change might push out to the PTR the next time we patch it. :) Bang at it and please see if you can get it to break or work strangely.[ post edited by Rislyn ]
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post422316 |
Poster: Rislyn at 7/31/2006 5:23:49 PM PDT
Subject: Re: Slouken: Please add a toggle for bag scal |
| |
So I discovered the cause of the mystery, but not the source.
For some reason, the frame has an issue whenever I set the global container scale below 0.9... If it doesn't go below that, I don't get the nil frame error. Why? I'm not sure yet. :)
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=418680&p=#post423619 |
