Poster: Cladhaire at 7/17/2006 6:54:33 PM PDT
Subject: Slouken: RAID_ROSTER_UPDATE |
| |
Slouken, it looks like on the 0.12 PTR build, RAID_ROSTER_UPDATE is still firing when we're not in a raid. I believe this was added in 1.11 to resolve some other issue, but its causing the following code from RaidFrame.lua to fire:
if ( event == "RAID_ROSTER_UPDATE" ) then
RaidFrame_LoadUI();
RaidFrame_Update();
end
This has the effect of loading the Blizzard Raid UI regardless of raid state. MiniBlizzRaid is able to stop the extra frames from loading by hooking RaidFrame_LoadUI prior to PLAYER_ENTERING_WORLD, but it's probably bad because of the fact that it loads for everyone, negating the LoD benefit.
I can probably cover the following in my code, but I'm wondering if we can make a change like the following to ensure the raid UI is only loaded when necessary.
if ( event == "RAID_ROSTER_UPDATE" ) then
if ( GetNumRaidMembers() > 0 ) then
RaidFrame_LoadUI();
end
RaidFrame_Update();
end
Thanks for everything[ post edited by Cladhaire ]
http://cladhaire.wowinterface.com
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=416391&p=#post416391 |
| |
Poster: slouken at 7/18/2006 10:41:29 AM PDT
Subject: Re: Slouken: RAID_ROSTER_UPDATE |
| |
Q u o t e:
When it was first added, Slouken stated that LoadAddOn is relatively inexpensive and you can safely and efficiently just call it without bothering to check whether stuff is currently loaded or not. :)
Yep, it's about the same cost to check to see if it's loaded, and actually try to load it if it's already loaded.
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=416391&p=#post416664 |
Poster: slouken at 7/18/2006 11:29:37 AM PDT
Subject: Re: Slouken: RAID_ROSTER_UPDATE |
| |
In 1.12 RAID_ROSTER_UPDATE will not be sent if you're not in a raid when entering the world.
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=416391&p=#post416690 |
Poster: slouken at 7/18/2006 2:03:06 PM PDT
Subject: Re: Slouken: RAID_ROSTER_UPDATE |
| |
Q u o t e:
Thank you kindly =)
You're welcome. :)
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=416391&p=#post416843 |
