WoW BlueTracker Home | RSS | News | Contact
Recent | Search | Archive | CS Posts
Poster: Guvante at 3/29/2006 10:53:57 AM PST
Subject: Bug in the FrameXML
   There seems to be a bit of a bug in the Blizzard_CraftUI.lua code, here is a snippet, from line 239 - 251:
-- Set the expand/collapse all button texture

local numHeaders = 0;
local notExpanded = 0;
for i=1, numCrafts, 1 do
local index = i + craftOffset;
local craftName, craftSubSpellName, craftType, numAvailable, isExpanded = GetCraftInfo(index);
if ( craftName and craftType == "header" ) then
numHeaders = numHeaders + 1;
if ( not isExpanded ) then
notExpanded = notExpanded + 1;
end
end
end
It seems that on line 243 (local index = i + craftOffset;) you are adding the offset of the screen to the item you really want to look at, which means, you are requesting the wrong data from the client

This normally is not a problem due to the fact that the default Craft Frame does not use headers, but my mod changes that, and this bug makes it throw nil errors and causes this section of code to run improperly near the bottom of the screen (It hides the header offset, even though there are headers)

The only fix I can do for now is to just return nil's on invalid id's (Should have done that in the first place anyways :S), and just say that the second bug is a bug in my program

Unfortunatly, the only way to fix this from my end is to overwrite the function entirely, which is a bad thing to do


Figured I would bring it up to the Devs so that it could be fixed in a future patch (Which I had found it prior to the patch release though :( )

BTW: the easiest fix is just to remove the "index" local variable from that section, and pass i into GetCraftInfo(), in case that helps ;)


EDIT: Copying to the Bugs Forum, since I just remembered it existed :P

[ post edited by Guvante ]


SortEnchant-http://curse-gaming.com/mod.php?addid=553
  http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=345979&p=#post345979
 
Poster: slouken at 3/30/2006 12:04:38 PM PST
Subject: Re: Bug in the FrameXML
  

Q u o t e:
BTW: the easiest fix is just to remove the "index" local variable from that section, and pass i into GetCraftInfo(), in case that helps ;)



Fixed, thanks!
  http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=345979&p=#post348968
Poster: slouken at 3/30/2006 12:05:04 PM PST
Subject: Re: Bug in the FrameXML
  

Q u o t e:

This time in Blizzard_CraftUI.xml line 325
TradeSkillCollapseAllButton_OnClick();

Which should be CraftCollapseAllButton_OnClick();



Fixed, thanks!
  http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=345979&p=#post348969

View all recent official Blue Posts

WoW Blue Tracker: Archiving World of Warcraft Blue Posts
since March 2005
Home | RSS | News | Contact
Recent | Search | Archive | CS Posts
 

Why Ads?