Poster: Iriel at 9/15/2005 1:46:21 PM PDT
Subject: Slouken: Some 1.7 Default API Bugs/Quirks |
| |
1) /chatlog and /combat log fail from macros (and possibly many other places)
Both of these command handlers reference the global 'this', which isn't safe from macros or from anyone's code which calls slash commands directly.
It should probably be replaced with DEFAULT_CHAT_FRAME
2) New 'optimized' ranged red-out of shortcut ID's lags behind actionbar page updates.
I recommend adding this new code at around line 283 of ActionButton.lua
if ( event == "ACTIONBAR_PAGE_CHANGED" or event == "PLAYER_AURAS_CHANGED" or event == "UPDATE_BONUS_ACTIONBAR" ) then
ActionButton_Update();
ActionButton_UpdateState();
if (this.rangeTimer) then
this.rangeTimer = -1;
end
return;
end
> Use ## SavedVariables: instead of RegisterForSave()
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=219456&p=#post219456 |
| |
Poster: slouken at 9/15/2005 2:15:33 PM PDT
Subject: Re: Slouken: Some 1.7 Default API Bugs/Quirks |
| |
Q u o t e:
1) /chatlog and /combat log fail from macros (and possibly many other places)
Both of these command handlers reference the global 'this', which isn't safe from macros or from anyone's code which calls slash commands directly.
It should probably be replaced with DEFAULT_CHAT_FRAME
Thanks, this is taken care of for 1.8
Q u o t e:
2) New 'optimized' ranged red-out of shortcut ID's lags behind actionbar page updates.
I recommend adding this new code at around line 283 of ActionButton.lua
if ( event == "ACTIONBAR_PAGE_CHANGED" or event == "PLAYER_AURAS_CHANGED" or event == "UPDATE_BONUS_ACTIONBAR" ) then
ActionButton_Update();
ActionButton_UpdateState();
if (this.rangeTimer) then
this.rangeTimer = -1;
end
return;
end
I have perhaps a better fix (?)
in ActionButton_Update()...
this.rangeTimer = TOOLTIP_UPDATE_TIME;
-->
this.rangeTimer = -1
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=219456&p=#post219502 |
Poster: slouken at 9/15/2005 2:40:27 PM PDT
Subject: Re: Slouken: Some 1.7 Default API Bugs/Quirks |
| |
Right, if it's -1, we do update stuff and then set the update timer to the next tooltip update time... isn't that what we want? (must be missing something)
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=219456&p=#post219551 |
Poster: slouken at 9/15/2005 2:58:55 PM PDT
Subject: Re: Slouken: Some 1.7 Default API Bugs/Quirks |
| |
Um, did you actually try my fix?
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=219456&p=#post219578 |
Poster: slouken at 9/15/2005 3:07:23 PM PDT
Subject: Re: Slouken: Some 1.7 Default API Bugs/Quirks |
| |
Heheh
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=219456&p=#post219587 |
Poster: slouken at 9/15/2005 3:38:40 PM PDT
Subject: Re: Slouken: Some 1.7 Default API Bugs/Quirks |
| |
BTW Iriel, you rock.
No, I don't have pre power. :)
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=219456&p=#post219623 |
Poster: slouken at 9/15/2005 3:48:05 PM PDT
Subject: Re: Slouken: Some 1.7 Default API Bugs/Quirks |
| |
A better fix, which accounts for variable framerate might be:
if ( this.rangeTimer ) then
this.rangeTimer = this.rangeTimer - elapsed;
if ( this.rangeTimer <= 0 ) then
-- do stuff
this.rangeTimer = TOOLTIP_UPDATE_TIME;
end
end
Edit: Well, technically, it should probably be this.rangeTimer = this.rangeTimer + TOOLTIP_UPDATE_TIME smoothed to handle drift, but that's way too much engineering for this. :)[ post edited by slouken ]
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=219456&p=#post219635 |
Poster: slouken at 9/15/2005 3:56:18 PM PDT
Subject: Re: Slouken: Some 1.7 Default API Bugs/Quirks |
| |
Okay, now back to important fixes. :)
*splat*
Take that!
*splat*
*squish*
Ewwww.... *wipes bug bits off his fingers*
|
| | http://forums.worldofwarcraft.com/thread.aspx?fn=wow-interface-customization&t=219456&p=#post219645 |
